Additional checks in tissue sample validation#39
Merged
Conversation
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to interact with Checkmarx PR Assistant. |
sarahgonicholson
approved these changes
Apr 1, 2026
Contributor
sarahgonicholson
left a comment
sarahgonicholson
left a comment
There was a problem hiding this comment.
Looks good. We may want to have this check only apply to NDRI TissueSamples, just because GCCs are more variable with the pattern of their submitted_ids. That or have this check throw a warning instead of a failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Almost every TPC submission I catch cases of mismatches between submitted_id and external_id or more often TissueSample submitted/external_id mismatches with the sample_sources tissue submitted_id on the same sheet which is not caught until actual submission.
2 new validator functions now check for this.
Unit tests included.